Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for language spec update? compiler-inserted default_action is not const #452

Closed
jafingerhut opened this issue Aug 15, 2023 · 3 comments
Labels
p4-language-compatibility An issue related to compatibility between P4_16 language spec and P4Runtime API spec

Comments

@jafingerhut
Copy link
Contributor

jafingerhut commented Aug 15, 2023

This issue is related to the following change made from v1.2.3 to v1.2.4 of the P4_16 language specification:

  • compiler-inserted default_action is not const (Section 14.2).

Basically, if a table definition has no explicit default_action property, the compiler behaves as if the user wrote the property default_action = NoAction();, and adds NoAction to the list of actions if it was not there already.

(see https://p4.org/p4-spec/docs/P4-16-v1.2.4.html#sec-summary-of-changes-made-in-version-124 for the item in context of the full list of changes, but there are separate Github issues for each that might impact the P4Runtime API specification).

This seems worth at least briefly discussing in API work group, but my guess is that this is really just a clarification in the language spec that says explicitly what has already been done for years in the open source P4 implementations.

@jafingerhut jafingerhut added the p4-language-compatibility An issue related to compatibility between P4_16 language spec and P4Runtime API spec label Aug 15, 2023
@jafingerhut
Copy link
Contributor Author

2023-Sep-08: Decision made that no P4Runtime spec changes needed, so remove this item from bullet list in spec.

@jafingerhut
Copy link
Contributor Author

This issue can be closed if/when PR #459 is merged.

@jafingerhut
Copy link
Contributor Author

PR #459 was merged, so closing this issue as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p4-language-compatibility An issue related to compatibility between P4_16 language spec and P4Runtime API spec
Projects
None yet
Development

No branches or pull requests

1 participant