-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intel compiler warnings in JSON code #102
Comments
Or perhaps I learn how hot fix works more under git flow. |
Drat there are other problems that Travis didn't catch under Intel compiler. We definitely need |
Yes the hot fix does remake a tag when it's closed. |
The issue in the JSON serializer github |
Since I disabled the intel warning, I will make this not need any further action before 0.7.0 |
NB: we will keep issue open until the json issue is resolved and version updated |
nlohmann/json#550 |
And JSON is what make the Intel builds fail at CI, this is our only red mark. If Guido is busy at the conference I can try to have a look.
Antonin
… On 19 Jun 2017, at 12:05, Peter Boyle ***@***.***> wrote:
nlohmann/json#550
Looks like the issue has been resolved on their GitHub, and this is continuing to cause TeamCity to send noisy fail messages. Can you update the JSON please to make the intel compile problem go away ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Closing (not merged in develop yet) |
I think the warnings under the intel compiler from JSON.hpp are unacceptably high and means we need a release v0.7.1 to fix it.
The text was updated successfully, but these errors were encountered: