-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extra space in argument's rendered markdown #363
Comments
Hmm... I'll see what I can do. I'm not really 100% happy with how markdown rendered either. |
Side note: for other data sources I ended up parsing to another data structure and render some markdowns ... e.g. json schema to markdown: https://github.com/oxc-project/oxc/blob/main/tasks/website/src/linter/json_schema.rs Maybe it's better to construct a data structure instead of collecting to html and then render from the html, the user could can use the data structure instead. But this is a lot of rework 😅 |
Thanks for the quick response! While we are at it, my weirdly added doc comment https://github.com/oxc-project/oxc/blob/3671b5c4d0a56a2edd005bbd8710036ee61376d2/crates/oxc_cli/src/command/lint.rs#L79 produced something that looks like a missing newline
Notice there is no newline before |
Rendered example:
Concrete example from test case
codeblock_ticks_help
:bpaf/tests/markdown.rs
Line 245 in a479b6b
After an hour of debugging I found it's inserting the space here
bpaf/src/meta_help.rs
Line 510 in a479b6b
but removing it will break everything else.
And I wasn't able to hack it in the markdown renderer, the input
bpaf/src/buffer/html.rs
Line 326 in a479b6b
came in as
so the split below
bpaf/src/buffer/html.rs
Line 334 in a479b6b
produces
and I don't know what to do next, hence this issue 😅
The text was updated successfully, but these errors were encountered: