Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plug-in functions #335

Closed
zmoth opened this issue Nov 28, 2022 · 6 comments
Closed

Plug-in functions #335

zmoth opened this issue Nov 28, 2022 · 6 comments

Comments

@zmoth
Copy link
Contributor

zmoth commented Nov 28, 2022

Hello @paceholder, are you going to implement plugins in version 3? I implemented a simple dynamic link library management based on the second version.
https://github.com/QianMoth/nodeeditor-p.git
https://github.com/QianMoth/PluginDemo.git
I wish there was a better solution, preferably one that doesn't rely on node.dll and uses only a few header files when making plug-ins.

你好,你打算在第三版本实现插件功能么?我基于第二版本实现了一个简单动态链接库的管理。
https://github.com/QianMoth/nodeeditor-p.git
https://github.com/QianMoth/PluginDemo.git
我希望有更好的解决方案,最好在制作插件的时候不需要依赖node.dll,只使用少量的头文件。

@isteelcx
Copy link

@QianMoth 你是不是把翻译软件的中文也粘贴过来了?

@paceholder
Copy link
Owner

Hi @QianMoth ,

what exactly do you mean under "plugins "? What do your plugins do?

Thanks for the clarifications

@zmoth
Copy link
Contributor Author

zmoth commented Nov 28, 2022

Hi @QianMoth ,

what exactly do you mean under "plugins "? What do your plugins do?

Thanks for the clarifications

ummm, My idea is that every node, or every type of node (such as Image Load Node), can be made into a plug-in (a '.dll 'file in windows).
I can then use the plug-in manager to invoke the DataModelRegistry function to dynamically add or remove new nodes.
This allows you to add new functionality without changing the code

@zmoth
Copy link
Contributor Author

zmoth commented Nov 28, 2022

Originally I had two plugins, three nodes. When I removed one of the plug-ins called tcp and reloaded it, I was left with only one node called demo. The same goes for adding nodes

4a0hr-q0v2d.mp4

@paceholder
Copy link
Owner

Thanks for the video. I think your plugin system lies beyond the scope of the current project. Node editor mainly focuses on graphics and does not imply any logic behind your node model. Your work looks like a good extension to the existing code. Can you just import node editor into your project and extend its classes? For example, you could extend the Node Data Model Registry to make it capable of loading dlls

What do you think?

@zmoth
Copy link
Contributor Author

zmoth commented Nov 28, 2022

Thanks for the video. I think your plugin system lies beyond the scope of the current project. Node editor mainly focuses on graphics and does not imply any logic behind your node model. Your work looks like a good extension to the existing code. Can you just import node editor into your project and extend its classes? For example, you could extend the Node Data Model Registry to make it capable of loading dlls

What do you think?

Thank you very much for your answer! I will try to do it in the direction you said.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants