Skip to content

Commit 6833cba

Browse files
committed
Merge branch 'main' into testthat3e
1 parent 7c43850 commit 6833cba

File tree

3 files changed

+18
-8
lines changed

3 files changed

+18
-8
lines changed

cpp11test/src/cpp11.cpp

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -701,12 +701,12 @@ static const R_CallMethodDef CallEntries[] = {
701701
{"_cpp11test_gibbs_rcpp2", (DL_FUNC) &_cpp11test_gibbs_rcpp2, 2},
702702
{"_cpp11test_grow_", (DL_FUNC) &_cpp11test_grow_, 1},
703703
{"_cpp11test_grow_cplx_", (DL_FUNC) &_cpp11test_grow_cplx_, 1},
704-
{"_cpp11test_mat_mat_copy_dimnames", (DL_FUNC) &_cpp11test_mat_mat_copy_dimnames, 1},
705-
{"_cpp11test_mat_mat_create_dimnames", (DL_FUNC) &_cpp11test_mat_mat_create_dimnames, 0},
706-
{"_cpp11test_mat_sexp_copy_dimnames", (DL_FUNC) &_cpp11test_mat_sexp_copy_dimnames, 1},
707704
{"_cpp11test_grow_strings_cpp11_", (DL_FUNC) &_cpp11test_grow_strings_cpp11_, 2},
708705
{"_cpp11test_grow_strings_manual_", (DL_FUNC) &_cpp11test_grow_strings_manual_, 2},
709706
{"_cpp11test_grow_strings_rcpp_", (DL_FUNC) &_cpp11test_grow_strings_rcpp_, 2},
707+
{"_cpp11test_mat_mat_copy_dimnames", (DL_FUNC) &_cpp11test_mat_mat_copy_dimnames, 1},
708+
{"_cpp11test_mat_mat_create_dimnames", (DL_FUNC) &_cpp11test_mat_mat_create_dimnames, 0},
709+
{"_cpp11test_mat_sexp_copy_dimnames", (DL_FUNC) &_cpp11test_mat_sexp_copy_dimnames, 1},
710710
{"_cpp11test_my_message", (DL_FUNC) &_cpp11test_my_message, 2},
711711
{"_cpp11test_my_message_n1", (DL_FUNC) &_cpp11test_my_message_n1, 1},
712712
{"_cpp11test_my_message_n1fmt", (DL_FUNC) &_cpp11test_my_message_n1fmt, 1},
@@ -719,10 +719,12 @@ static const R_CallMethodDef CallEntries[] = {
719719
{"_cpp11test_my_warning_n1", (DL_FUNC) &_cpp11test_my_warning_n1, 1},
720720
{"_cpp11test_my_warning_n1fmt", (DL_FUNC) &_cpp11test_my_warning_n1fmt, 1},
721721
{"_cpp11test_my_warning_n2fmt", (DL_FUNC) &_cpp11test_my_warning_n2fmt, 2},
722-
{"_cpp11test_ordered_map_to_list_", (DL_FUNC) &_cpp11test_ordered_map_to_list_, 1},
723-
{"_cpp11test_ordered_map_to_list_2_", (DL_FUNC) &_cpp11test_ordered_map_to_list_2_, 1},
722+
{"_cpp11test_notroxcpp1_", (DL_FUNC) &_cpp11test_notroxcpp1_, 1},
723+
{"_cpp11test_notroxcpp6_", (DL_FUNC) &_cpp11test_notroxcpp6_, 1},
724724
{"_cpp11test_nullable_extptr_1", (DL_FUNC) &_cpp11test_nullable_extptr_1, 0},
725725
{"_cpp11test_nullable_extptr_2", (DL_FUNC) &_cpp11test_nullable_extptr_2, 0},
726+
{"_cpp11test_ordered_map_to_list_", (DL_FUNC) &_cpp11test_ordered_map_to_list_, 1},
727+
{"_cpp11test_ordered_map_to_list_2_", (DL_FUNC) &_cpp11test_ordered_map_to_list_2_, 1},
726728
{"_cpp11test_protect_many_", (DL_FUNC) &_cpp11test_protect_many_, 1},
727729
{"_cpp11test_protect_many_cpp11_", (DL_FUNC) &_cpp11test_protect_many_cpp11_, 1},
728730
{"_cpp11test_protect_many_preserve_", (DL_FUNC) &_cpp11test_protect_many_preserve_, 1},

cpp11test/src/matrix.cpp

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,8 +143,17 @@ using namespace Rcpp;
143143
out(1, 1) = 4;
144144

145145
cpp11::writable::list dimnames(2);
146-
dimnames[0] = cpp11::strings({"a", "b"});
147-
dimnames[1] = cpp11::strings({"c", "d"});
146+
// Avoid brace-initializer (std::initializer_list) to prevent emitting
147+
// an initializer_list constructor reference across TUs. Use push_back.
148+
cpp11::writable::strings dn0;
149+
dn0.push_back("a");
150+
dn0.push_back("b");
151+
dimnames[0] = dn0;
152+
153+
cpp11::writable::strings dn1;
154+
dn1.push_back("c");
155+
dn1.push_back("d");
156+
dimnames[1] = dn1;
148157

149158
out.attr("dimnames") = dimnames;
150159

tests/testthat/test-vendor.R

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,5 +28,4 @@ test_that("cpp_vendor vendors cpp11", {
2828
expect_true(file.exists(file.path(p, "inst", "include", "cpp11", "declarations.hpp")))
2929

3030
expect_silent(cpp_unvendor(pkg_path(pkg)))
31-
})
3231
})

0 commit comments

Comments
 (0)