Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No sample found for any GEO entries #65

Closed
NaotoKubota opened this issue Feb 27, 2024 · 5 comments
Closed

No sample found for any GEO entries #65

NaotoKubota opened this issue Feb 27, 2024 · 5 comments

Comments

@NaotoKubota
Copy link

NaotoKubota commented Feb 27, 2024

Hi, I report that ffq was not able to fetch fastq URL for any GEO entries right now.

For example, I tried to download metadata for GSE66230 like this:

ffq --verbose GSE66230 -o ./

The log says like ERROR 404 Client Error: for url: https://www.ebi.ac.uk/ena/browser/api/xml/SRX886447/ and WARNING No sample found for any samples.
I tried other entries many times and got the same error each time.
It looks problems of GEO ENA side but just in case I report this here.

Thanks,

@hazirliver
Copy link
Contributor

hazirliver commented Feb 27, 2024

Hi,

I am encountering the same issue as reported. I also receive a 404 Client Error when attempting to fetch URLs for various entries, indicating a possible issue with ENA's server.

Does anyone know the appropriate contact or procedure to request a server check or reboot on ENA's side?

Thank you

@pedrocr83
Copy link

I also report the same behaviour and also running ffq SRR7613775 returns "Provided accession is invalid"

@pedrocr83
Copy link

solution for this issue can be found #60

@hazirliver
Copy link
Contributor

Hello everyone,

I've investigated the errors we've been encountering with fetching data for GEO entries and found that the issue seems to stem from the URL format used in the get_xml function within ffq/utils.py. Specifically, the API requests were failing due to a trailing slash at the end of the ENA URL.

By removing this trailing slash from the URL, I was able to successfully fetch data without encountering the 404 Client Error. This modification allows proper URL formation and aligns with the updated API requirements of ENA.

I have submitted a Pull Request to address this issue: Fix: Remove trailing slash from ENA URL in get_xml #66. If merged, this should resolve the 'No sample found for any GEO entries' error by ensuring correct data retrieval from the ENA database.

@sbooeshaghi
Copy link
Collaborator

Thank you @hazirliver for your contributions. I have incorporated your bug fix into the ffq codebase and have updated the package on GitHub and on pip. These examples should now work.

https://pypi.org/project/ffq/0.3.1/

Thank you all again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants