Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There shoud be a reasonable, default timeout #107

Open
grahamc opened this issue Mar 3, 2021 · 2 comments
Open

There shoud be a reasonable, default timeout #107

grahamc opened this issue Mar 3, 2021 · 2 comments

Comments

@grahamc
Copy link
Contributor

grahamc commented Mar 3, 2021

Plus, it'd be great to have it be settable. Just today I noticed a process blocked trying to talk to the EM API for 33 hours.

@displague
Copy link
Member

This sounds reasonable. https://docs.python-requests.org/en/master/user/advanced/#timeouts offers the means to do this.

I think we would want to introduce this on a call-by-call basis via call_api, https://github.com/packethost/packet-python/blob/v1.44.0/packet/baseapi.py#L47. Perhaps adding an extra argument.

@displague displague added this to the Future Roadmap milestone May 26, 2021
@WeijuZheng
Copy link

Will this issue be fixed soon? If not, any work around to set a timeout for all the request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants