Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify openshift cronjob deployment approach. #112

Closed
sakalosj opened this issue Aug 4, 2020 · 10 comments
Closed

Unify openshift cronjob deployment approach. #112

sakalosj opened this issue Aug 4, 2020 · 10 comments
Labels
good-first-issue Good for newcomers. stale Is the issue still valid?

Comments

@sakalosj
Copy link
Contributor

sakalosj commented Aug 4, 2020

Current state:

  • delete-pvcs and import-images use own make file
  • validation is deployed via separate target in root make file

The separate target in the root make file is preferred.

Consider incorporating into the global deployment process (make deploy).

@jpopelka
Copy link
Member

jpopelka commented Aug 13, 2020

Another thing to improve:

@lbarcziova was having a problem that the validation job was at some point not able to download the image from Docker Hub.
The reason (correct me if I'm wrong) was that she'd built & pushed the image with podman.
So if the cluster has problems with podman built&pushed images, then we should enforce using docker in those makefile targets.

@TomasTomecek
Copy link
Member

and/or report the podman problem is it gets resolved in future

@jpopelka
Copy link
Member

and/or report the podman problem is it gets resolved in future

yes, it might actually be the same problem as packit/packit-service#680

@stale
Copy link

stale bot commented Nov 13, 2020

This issue has been marked as stale because it hasn't seen any
activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed
by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! 🦄 🚀 🤖

(Note: issues labeled with pinned or EPIC are
never marked as stale.)

@stale stale bot added the stale Is the issue still valid? label Nov 13, 2020
@stale stale bot closed this as completed Nov 27, 2020
@jpopelka jpopelka added good-first-issue Good for newcomers. and removed stale Is the issue still valid? labels Nov 30, 2020
@lachmanfrantisek
Copy link
Member

@jpopelka Looks like you want this opened.

@jpopelka
Copy link
Member

jpopelka commented Dec 4, 2020

Whoever will do this, please also change rebuild-base-image to run once a week and not every day.
So that my images are not rebuilding over and over again when I'm working on something for more days.

@jpopelka
Copy link
Member

jpopelka commented Dec 11, 2020

and/or report the podman problem is it gets resolved in future

docker/hub-feedback#1871 looks like the same problem

EDIT: I got the link from https://github.com/marketplace/actions/buildah-build#action-inputs

@TomasTomecek
Copy link
Member

latest comment in the hub tracker seems to indicate the images can now be pulled

@stale
Copy link

stale bot commented Mar 5, 2021

This issue has been marked as stale because it hasn't seen any
activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed
by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! 🦄 🚀 🤖

(Note: issues labeled with pinned or EPIC are
never marked as stale.)

@stale stale bot added the stale Is the issue still valid? label Mar 5, 2021
@jpopelka
Copy link
Member

jpopelka commented Mar 8, 2021

validation is deployed via separate target in root make file

I don't see any such target in the main Makefile, only in cron-jobs/validation/Makefile.
So all the cron-jobs are being deployed by their own Makefiles. Closing

All the other comments are being resolved by building images via Github Actions and using Quay.io as image registry.

@jpopelka jpopelka closed this as completed Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Good for newcomers. stale Is the issue still valid?
Projects
None yet
Development

No branches or pull requests

4 participants