Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel running jobs when new ones are started for a PR #5

Open
TomasTomecek opened this issue Jan 9, 2019 · 26 comments
Open

Cancel running jobs when new ones are started for a PR #5

TomasTomecek opened this issue Jan 9, 2019 · 26 comments
Labels
area/copr Related to the integration with copr.fedorainfracloud.org/ area/testing-farm Related to Testing Farm integration. kind/feature New feature or a request for enhancement. triaged This issue was already processed by the team.

Comments

@TomasTomecek
Copy link
Member

TomasTomecek commented Jan 9, 2019

It can easily happen that a PR can receive a push or a /packit copr-build command and then another one in a short time-span.

In order to not to waste resources and avoid publishing results from a parallel set of jobs into the same PR, we should cancel old jobs (builds, tests) and submit new ones.

@TomasTomecek TomasTomecek transferred this issue from packit/packit May 23, 2019
@TomasTomecek TomasTomecek changed the title Cancel old jobs if a new push came Cancel old copr build if a new push came to a PR May 23, 2019
@rpitonak rpitonak added the kind/feature New feature or a request for enhancement. label Aug 2, 2019
@lachmanfrantisek lachmanfrantisek added area/copr Related to the integration with copr.fedorainfracloud.org/ triaged This issue was already processed by the team. labels Aug 15, 2019
@stale

This comment has been minimized.

@stale stale bot added the stale Is the issue still valid? label Nov 5, 2019
@TomasTomecek
Copy link
Member Author

I wonder if copr optimizes this on its own - cancels old builds if new are requested in a project.

@stale stale bot removed the stale Is the issue still valid? label Nov 5, 2019
@stale

This comment has been minimized.

@stale stale bot added the stale Is the issue still valid? label Jan 4, 2020
@TomasTomecek TomasTomecek removed the stale Is the issue still valid? label Jan 7, 2020
@TomasTomecek
Copy link
Member Author

with postgres this can be now done so easily honestly

@TomasTomecek TomasTomecek added the good-first-issue Good for newcomers. label Mar 2, 2020
@csomh csomh changed the title Cancel old copr build if a new push came to a PR Cancel running jobs when new ones are started for a PR Mar 23, 2020
@stale

This comment has been minimized.

@stale stale bot added the stale Is the issue still valid? label May 22, 2020
@stale stale bot closed this as completed Jun 5, 2020
@TomasTomecek
Copy link
Member Author

we should still investigate if copr can do this on it own

@TomasTomecek TomasTomecek reopened this Jun 5, 2020
@stale stale bot removed the stale Is the issue still valid? label Jun 5, 2020
@stale

This comment has been minimized.

@stale stale bot added the stale Is the issue still valid? label Aug 4, 2020
@TomasTomecek TomasTomecek removed the stale Is the issue still valid? label Aug 5, 2020
@stale

This comment has been minimized.

@stale stale bot added the stale Is the issue still valid? label Oct 4, 2020
@lachmanfrantisek lachmanfrantisek removed the stale Is the issue still valid? label Oct 5, 2020
@lachmanfrantisek
Copy link
Member

Related to #785

@stale

This comment has been minimized.

@stale
Copy link

stale bot commented Nov 25, 2021

This issue has been marked as stale because it hasn't seen any
activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed
by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! 🦄 🚀 🤖

(Note: issues labeled with pinned or EPIC are
never marked as stale.)

@stale stale bot added the stale Is the issue still valid? label Nov 25, 2021
@TomasTomecek TomasTomecek removed the stale Is the issue still valid? label Dec 9, 2021
@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been marked as stale because it hasn't seen any
activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed
by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! 🦄 🚀 🤖

(Note: issues labeled with pinned or EPIC are
never marked as stale.)

@stale stale bot added the stale Is the issue still valid? label Mar 2, 2022
@csomh csomh removed the stale Is the issue still valid? label Mar 2, 2022
@stale
Copy link

stale bot commented May 1, 2022

This issue has been marked as stale because it hasn't seen any
activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed
by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! 🦄 🚀 🤖

(Note: issues labeled with pinned or EPIC are
never marked as stale.)

@stale stale bot added the stale Is the issue still valid? label May 1, 2022
@csomh csomh removed the stale Is the issue still valid? label May 2, 2022
@stale
Copy link

stale bot commented Jul 10, 2022

This issue has been marked as stale because it hasn't seen any
activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed
by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! 🦄 🚀 🤖

(Note: issues labeled with pinned or EPIC are
never marked as stale.)

@stale stale bot added the stale Is the issue still valid? label Jul 10, 2022
@csomh csomh removed the stale Is the issue still valid? label Jul 11, 2022
@stale
Copy link

stale bot commented Sep 21, 2022

This issue has been marked as stale because it hasn't seen any
activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed
by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! 🦄 🚀 🤖

(Note: issues labeled with pinned or EPIC are
never marked as stale.)

@stale stale bot added the stale Is the issue still valid? label Sep 21, 2022
@csomh csomh removed the stale Is the issue still valid? label Sep 29, 2022
@lbarcziova
Copy link
Member

We discussed this and decided we will drop this issue since we are not able to plan this in the near future and the implementation could be more complex (since the codebase changed a lot since opening this issue) and lead to race conditions.

@lbarcziova lbarcziova closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2022
Repository owner moved this from backlog to done in Packit Kanban Board Dec 6, 2022
@lbarcziova
Copy link
Member

Reopening given the increased user base and since it would help with resource management and address challenges such as handling outages where queues become overloaded. This would prevent unnecessary triggers of builds/tests when a pull request is updated during such outages.

This was also asked by @evgeni in the chat recently.

@lbarcziova lbarcziova reopened this May 15, 2024
@bocekm
Copy link

bocekm commented May 23, 2024

+1 to this RFE!

When I trigger copr building and integration test execution on https://github.com/oamg/convert2rhel PRs, that's a lot of jobs. When I trigger that all again, for example by pushing to the PR branch, before even copr builds are created then the Testing Farm jobs that follow up after copr builds don't need to be even run. That might even save some GitHub App requests which are limited and our project has been hiting the limit https://docs.github.com/en/rest/using-the-rest-api/rate-limits-for-the-rest-api?primary-rate-limit-for-github-app-installations=&apiVersion=2022-11-28#primary-rate-limit-for-github-app-installations.

@mfocko mfocko moved this from done to backlog in Packit Kanban Board Jun 6, 2024
@lbarcziova lbarcziova removed the good-first-issue Good for newcomers. label Jun 18, 2024
@lbarcziova lbarcziova moved this from backlog to priority-backlog in Packit Kanban Board Jun 18, 2024
@lbarcziova lbarcziova added the area/testing-farm Related to Testing Farm integration. label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/copr Related to the integration with copr.fedorainfracloud.org/ area/testing-farm Related to Testing Farm integration. kind/feature New feature or a request for enhancement. triaged This issue was already processed by the team.
Projects
Status: priority-backlog
Development

No branches or pull requests

7 participants