Default PactFileWriteMode silently fails in VerifyMessageConsumer

[alexeits]

Software versions

• OS: macOS 10.13.6 (17G65)

• Consumer Pact library: pact-go v1.0.0-beta.2

• Golang Version: go version go1.10.3 darwin/amd64

• Golang environment:

  GOARCH="amd64"
  GOBIN=""
  GOCACHE="/Users/alex/Library/Caches/go-build"
  GOEXE=""
  GOHOSTARCH="amd64"
  GOHOSTOS="darwin"
  GOOS="darwin"
  GOPATH="/Users/alex/Documents/source/go"
  GORACE=""
  GOROOT="/usr/local/Cellar/go/1.10.3/libexec"
  GOTMPDIR=""
  GOTOOLDIR="/usr/local/Cellar/go/1.10.3/libexec/pkg/tool/darwin_amd64"
  GCCGO="gccgo"
  CC="clang"
  CXX="clang++"
  CGO_ENABLED="1"
  CGO_CFLAGS="-g -O2"
  CGO_CPPFLAGS=""
  CGO_CXXFLAGS="-g -O2"
  CGO_FFLAGS="-g -O2"
  CGO_LDFLAGS="-g -O2"
  PKG_CONFIG="pkg-config"
  GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/5v/fvbqg92n7wg1vkr3gg4glvyh0000gn/T/go-build756609652=/tmp/go-build -gno-record-gcc-switches -fno-common"
  

Expected behaviour

The unspecified / default PactFileWriteMode should produce a pact file

Actual behaviour

The default PactFileWriteMode silently fails to produce a pact file

Steps to reproduce

1. Configure pact as follows:

   pact = &dsl.Pact{
   	Consumer:  "PactGoMessageConsumer",
   	Provider:   "PactGoMessageProvider",
   	PactDir:    "/path/to/pacts",
   }

2. Run any pact using VerifyPactMessage (the consumer example would do)

3. Observe that no pact file is produced

4. Add PactFileWriteMode: "update" to the pact struct initializer

5. Verify that pact is being produced

[mefellows]

Good spot. I've pushed up a small change now that should sort it out. If you could please confirm, I'll bump the version.

[alexeits]

Yes, the fix works great, thank you.

[mefellows]

Thanks for the report!