Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releasing snags #108

Closed
YOU54F opened this issue Sep 12, 2023 · 3 comments
Closed

Releasing snags #108

YOU54F opened this issue Sep 12, 2023 · 3 comments

Comments

@YOU54F
Copy link
Member

YOU54F commented Sep 12, 2023

We haven't needed to push out any releases since Oct 2021, there are some snags at the moment, so here are some notes on the current release process

  1. Out of date notes?
  1. Release workflow not currently working

I don't think step 1 is needed anymore and should be replaced with step 2

@YOU54F
Copy link
Member Author

YOU54F commented Sep 12, 2023

Release is out now

  1. Updated release-gem to 0.0.14 tag
  2. Executed release with ./script/trigger-release.sh minor

TODO

  1. Update RELEASING.md to reflect new releasing instructions
  • set GITHUB_ACCESS_TOKEN_FOR_PF_RELEASES token in shell
  • ./script/trigger-release.sh <major|minor|patch>
  1. workflow_dispatch has no way to setting INCREMENT for release workflow. Pick one of the following
  • Remove workflow_dispatch
  • Update workflow_dispatch to set release increment
    • Note:- a choice value will always provide a default (the default cannot be blank)
    • defaulting to a "null" string would suffice, see ./script/trigger-release.sh
  1. Update peter-evans/repository-dispatch action, due to deprecation notices from node 12

@YOU54F
Copy link
Member Author

YOU54F commented Sep 12, 2023

Some thoughts on our semver and ruby required version

So background, for this, was #107 which bumped the ruby required version to 2.6 or greater so we wanted to ensure the correct semver bump

I’m not sure what is correct in ruby land in terms of package etiquette.

The PR introduces the restriction on minimum ruby version 2.6 or greater, so I just want to check if it should be bumped as a major or minor.

I would traditionally do a major in node-js projects on a language runtime restriction, but not sure if its done at minor level in ruby gems. (Gem versions seem to be much lower than equivalent npm packages, and it’s been around alot longer, which is why I want to clarify)

mixed opinions https://www.reddit.com/r/ruby/comments/7vtceq/when_is_it_okay_to_drop_support_for_ruby_versions/

Both semver specs and other sources such as gov.uk

We should then release the updated gem as a minor version. In the past, our policy was to release as a major version, but this was superfluous given that the change is low risk (Dependabot shouldn’t even raise a PR unless the upstream app is on a supported Ruby version). It also limited our ability to benefit from the automated workflows agreed in RFC-156, which apply only to patch and minor version upgrades. Note that patch versions are generally reserved only for bug fixes.

@YOU54F
Copy link
Member Author

YOU54F commented Feb 9, 2024

believe this is sorted

@YOU54F YOU54F closed this as completed Feb 9, 2024
@github-project-automation github-project-automation bot moved this from Triaged to Closed in Pact Triage (not yet in use) Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

No branches or pull requests

1 participant