Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nameser include handling #4

Open
paddybyers opened this issue Oct 19, 2011 · 1 comment
Open

nameser include handling #4

paddybyers opened this issue Oct 19, 2011 · 1 comment

Comments

@paddybyers
Copy link
Owner

There are two interrelated issues:

  1. There is a lot of include logic relating to inclusion of nameser.h and the arpa variants that is duplicated across multiple files. Any change in the logic - in particular, and change that makes the logic more complex - makes the core progressively less maintainable.

  2. There is an implicit assumption in the existing logic that any platform with HAVE_ARPA_NAMESER_H also has HAVE_ARPA_NAMESER_COMPAT_H, and this isn't true on Android (it has nameser.h only).

The suggested fix is to move all of that inclusion logic into one include file, and to adjust the logic to accommodate the Android case.

Proposed changes:

dd60885
e30dad0
99e081c

@paddybyers
Copy link
Owner Author

I avoided doing this on the master-android branch just by saying that neither arpa include is available.

But .. there's a new problem which is that cares_wrap.cc depends on nameser.h, and this must be the cares substitute if the system does not have the arpa files itself.

There needs to be an ANDROID conditional:

f896c85

And so that this can be seen from the outside, the cares nameser.h needs to be in the include directory, not src:

1a5b65d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant