You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is a lot of include logic relating to inclusion of nameser.h and the arpa variants that is duplicated across multiple files. Any change in the logic - in particular, and change that makes the logic more complex - makes the core progressively less maintainable.
There is an implicit assumption in the existing logic that any platform with HAVE_ARPA_NAMESER_H also has HAVE_ARPA_NAMESER_COMPAT_H, and this isn't true on Android (it has nameser.h only).
The suggested fix is to move all of that inclusion logic into one include file, and to adjust the logic to accommodate the Android case.
I avoided doing this on the master-android branch just by saying that neither arpa include is available.
But .. there's a new problem which is that cares_wrap.cc depends on nameser.h, and this must be the cares substitute if the system does not have the arpa files itself.
There are two interrelated issues:
There is a lot of include logic relating to inclusion of nameser.h and the arpa variants that is duplicated across multiple files. Any change in the logic - in particular, and change that makes the logic more complex - makes the core progressively less maintainable.
There is an implicit assumption in the existing logic that any platform with HAVE_ARPA_NAMESER_H also has HAVE_ARPA_NAMESER_COMPAT_H, and this isn't true on Android (it has nameser.h only).
The suggested fix is to move all of that inclusion logic into one include file, and to adjust the logic to accommodate the Android case.
Proposed changes:
dd60885
e30dad0
99e081c
The text was updated successfully, but these errors were encountered: