fix: sonar issues

Author: RafaMelazzo

assets/javascripts/front/checkout/model/payment/card.js

@@ -256,14 +256,14 @@ let pagarmeCard = {
         if (!elem) {
             return false;
         }
-        let brand = elem.closest('fieldset').find(this.brandTarget).val();
+        const brand = elem.closest('fieldset').find(this.brandTarget).val();
         let total = elem.closest('fieldset').find(this.valueTarget).val();
         if (total) {
             total = pagarmeCard.formatValue(total);
         }
-        let cardForm = elem.closest("fieldset");
-        let select = cardForm.find(this.installmentsTarget);
-        let info = cardForm.find(this.installmentsInfoTarget);
+        const cardForm = elem.closest("fieldset");
+        const select = cardForm.find(this.installmentsTarget);
+        const info = cardForm.find(this.installmentsInfoTarget);
         if (!total) {
             total = cartTotal;
         }
@@ -273,9 +273,9 @@ let pagarmeCard = {
         ) {
             return false;
         }
-        let storageName = btoa(brand + total);
+        const storageName = btoa(brand + total);
         sessionStorage.removeItem(storageName);
-        let storage = sessionStorage.getItem(storageName);
+        const storage = sessionStorage.getItem(storageName);
         if (storage) {
             select.html(storage);
         } else {

src/Block/Checkout/Gateway.php

@@ -84,12 +84,12 @@ public function getConfigDataProvider()
 
     /**
      * @param string $id
-     * @return string
+     * @return string | null
      */
     public function getElementId(string $id)
     {
         if (!$this->getPaymentInstance()){
-            return;
+            return null;
         }
         return WCMP_PREFIX . '[' . $this->getPaymentInstance()->getMethodCode() . ']' . $id;
     }

templates/checkout/form/card/installments.phtml

@@ -20,16 +20,27 @@ if (!function_exists('add_action')) {
     <?php esc_html_e('Installments quantity', 'woo-pagarme-payments'); ?><span class="required">*</span>
 </label>
 
-<?php if ($this->showOneInstallmentInfo()) : ?>
-    <span data-pagarme-component="installments-info" class="pagarme-installments-info<?= $this->isCcInstallmentTypeByFlag() ? ' pagarme-hidden' : '' ?>">&mdash; <?= __('Your cart has one or more daily or weekly subscription products, which do not allow installments.', 'woo-pagarme-payments')?></span>
+<?php if ($this->showOneInstallmentInfo()) :
+    $installmentsInfo = __('Your cart has one or more daily or weekly subscription products, which do not allow '
+    . 'installments.', 'woo-pagarme-payments');
+?>
+    <span
+        data-pagarme-component="installments-info"
+        class="pagarme-installments-info<?= $this->isCcInstallmentTypeByFlag() ? ' pagarme-hidden' : '' ?>">
+            &mdash; <?= $installmentsInfo ?>
+    </span>
 <?php endif; ?>
 
-<select id="<?= $this->getElementId('installment') ?>" <?= $this->getInstallmentsComponent() ?> data-total="<?= esc_html($this->getCartTotals()); ?>" data-type="<?= $this->getInstallmentsType(); ?>" data-action="select2" data-required="true" data-element="installments" name="<?= $this->getElementId('installment') ?>">
-    <?php if ($this->isInterestForAllFlags()) : ?>
-        <?php foreach  ($this->render() as $options) : ?>
-            <option value="<?= $options['value'] ?>"><?= $options['content'] ?></option>
-        <?php endforeach; ?>
-    <?php else : ?>
-        <option value="">...</option>
-    <?php endif; ?>
+<select
+    id="<?= $this->getElementId('installment') ?>" <?= $this->getInstallmentsComponent() ?>
+    data-total="<?= esc_html($this->getCartTotals()); ?>" data-type="<?= $this->getInstallmentsType(); ?>"
+    data-action="select2" data-required="true" data-element="installments"
+    name="<?= $this->getElementId('installment') ?>">
+        <?php if ($this->isInterestForAllFlags()) : ?>
+            <?php foreach  ($this->render() as $options) : ?>
+                <option value="<?= $options['value'] ?>"><?= $options['content'] ?></option>
+            <?php endforeach; ?>
+        <?php else : ?>
+            <option value="">...</option>
+        <?php endif; ?>
 </select>