Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build script broken by newer version of rubocop #54

Closed
rdipardo opened this issue Feb 27, 2021 · 1 comment
Closed

Build script broken by newer version of rubocop #54

rdipardo opened this issue Feb 27, 2021 · 1 comment

Comments

@rdipardo
Copy link

Just reporting that I can locally reproduce the error output of this failed build with the following environment:

$ bundle list | awk '/slate /'
  * jekyll-theme-slate (0.1.1)
$ ruby -v
ruby 2.7.0p0 (2019-12-25 revision 647ee6f091) [x86_64-linux]

The problem is that running script/bootstrap installs a recent version of rubocop:

$ bundle list | awk '/rubocop /'
  * rubocop (0.93.1)

The linting step in script/cibuild fails because rubocop has added some fussy new cops that aren't being filtered.
Similar to #39, this can be easily fixed by updating .rubocop.yml. Here's a config that works:

AllCops:
  NewCops: enable
  Exclude:
    - _site/**/*
Layout/LineLength:
  Enabled: false
Gemspec/RequiredRubyVersion:
  Enabled: false
Style/CaseLikeIf:
  Enabled: false
@rdipardo
Copy link
Author

rdipardo commented Aug 2, 2021

Fixed by efa1cd0

@rdipardo rdipardo closed this as completed Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant