implement new durable utilities

Author: balanza

HandleNHCreateOrUpdateInstallationCallActivity/__tests__/handler.test.ts

@@ -1,8 +1,7 @@
 // tslint:disable:no-any
 import { NonEmptyString } from "italia-ts-commons/lib/strings";
 import { context as contextMock } from "../../__mocks__/durable-functions";
-import { getCallNHCreateOrUpdateInstallationActivityHandler } from "../handler";
-import { ActivityInput as NHServiceActivityInput } from "../handler";
+import { activityBody, ActivityInput, ActivityResultSuccess } from "../handler";
 
 import * as azure from "azure-sb";
 import { PlatformEnum } from "../../generated/backend/Platform";
@@ -13,6 +12,9 @@ import { NotificationHubConfig } from "../../utils/notificationhubServicePartiti
 
 import { envConfig } from "../../__mocks__/env-config.mock";
 import { Azure, NotificationHubService } from "azure-sb";
+import { createActivity } from "../../utils/durable/activities";
+
+const activityName = "any";
 
 const aFiscalCodeHash = "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855" as NonEmptyString;
 const aPushChannel =
@@ -49,6 +51,13 @@ const buildNHServiceMockBuilder = func =>
       } as undefined) as NotificationHubService;
     });
 
+const handler = createActivity(
+  activityName,
+  ActivityInput, // FIXME: the editor marks it as type error, but tests compile correctly
+  ActivityResultSuccess,
+  activityBody
+);
+
 describe("HandleNHCreateOrUpdateInstallationCallActivity", () => {
   beforeEach(() => {
     jest.clearAllMocks();
@@ -63,32 +72,35 @@ describe("HandleNHCreateOrUpdateInstallationCallActivity", () => {
         )
     );
 
-    const handler = getCallNHCreateOrUpdateInstallationActivityHandler();
-    const input = NHServiceActivityInput.encode({
+    const input = ActivityInput.encode({
       installationId: aCreateOrUpdateInstallationMessage.installationId,
       platform: aCreateOrUpdateInstallationMessage.platform,
       tags: aCreateOrUpdateInstallationMessage.tags,
       pushChannel: aCreateOrUpdateInstallationMessage.pushChannel,
       notificationHubConfig: aNHConfig
     });
+
     expect.assertions(2);
+
     await handler(contextMock as any, input);
+
     expect(buildNHServiceMock).toHaveBeenCalledTimes(1);
     expect(buildNHServiceMock).toBeCalledWith(aNHConfig);
   });
 
   it("should trigger a retry if CreateOrUpdateInstallation fails", async () => {
     buildNHServiceMockBuilder(createOrUpdateInstallation_WithError_Mock);
 
-    const handler = getCallNHCreateOrUpdateInstallationActivityHandler();
-    const input = NHServiceActivityInput.encode({
+    const input = ActivityInput.encode({
       installationId: aCreateOrUpdateInstallationMessage.installationId,
       platform: aCreateOrUpdateInstallationMessage.platform,
       tags: aCreateOrUpdateInstallationMessage.tags,
       pushChannel: aCreateOrUpdateInstallationMessage.pushChannel,
       notificationHubConfig: aNHConfig
     });
+
     expect.assertions(2);
+
     try {
       await handler(contextMock as any, input);
     } catch (e) {

HandleNHCreateOrUpdateInstallationCallActivity/handler.ts

@@ -1,31 +1,22 @@
-import { identity, toString } from "fp-ts/lib/function";
-import { fromEither } from "fp-ts/lib/TaskEither";
+import { toString } from "fp-ts/lib/function";
 import * as t from "io-ts";
 
-import { Context } from "@azure/functions";
-
 import { InstallationId } from "../generated/notifications/InstallationId";
 import { Platform } from "../generated/notifications/Platform";
 
-import { readableReport } from "italia-ts-commons/lib/reporters";
-
 import {
-  ActivityResult,
+  ActivityBody,
   ActivityResultSuccess,
-  failActivity,
-  retryActivity,
-  success
-} from "../utils/activity";
+  retryActivity
+} from "../utils/durable/activities";
 import { createOrUpdateInstallation } from "../utils/notification";
 import {
   buildNHService,
   NotificationHubConfig
 } from "../utils/notificationhubServicePartition";
 
-// Activity Name
-export const ActivityName = "HandleNHCreateOrUpdateInstallationCallActivity";
-
 // Activity input
+export type ActivityInput = t.TypeOf<typeof ActivityInput>;
 export const ActivityInput = t.interface({
   installationId: InstallationId,
   notificationHubConfig: NotificationHubConfig,
@@ -34,36 +25,24 @@ export const ActivityInput = t.interface({
   tags: t.readonlyArray(t.string, "array of string")
 });
 
-export type ActivityInput = t.TypeOf<typeof ActivityInput>;
-
-/**
- * For each Notification Hub Message of type "Delete" calls related Notification Hub service
- */
-export const getCallNHCreateOrUpdateInstallationActivityHandler = (
-  logPrefix = "NHCreateOrUpdateCallServiceActivity"
-) => async (context: Context, input: unknown) => {
-  const failure = failActivity(context, logPrefix);
-  return fromEither(ActivityInput.decode(input))
-    .mapLeft(errs =>
-      failure("Error decoding activity input", readableReport(errs))
-    )
-    .chain<ActivityResultSuccess>(activityInput => {
-      context.log.info(
-        `${logPrefix}|INSTALLATION_ID=${activityInput.installationId}`
-      );
-
-      const nhService = buildNHService(activityInput.notificationHubConfig);
-
-      return createOrUpdateInstallation(
-        nhService,
-        activityInput.installationId,
-        activityInput.platform,
-        activityInput.pushChannel,
-        activityInput.tags
-      ).mapLeft(e =>
-        retryActivity(context, `${logPrefix}|ERROR=${toString(e)}`)
-      );
-    })
-    .fold<ActivityResult>(identity, success)
-    .run();
+export { ActivityResultSuccess } from "../utils/durable/activities";
+
+export type ActivityBodyImpl = ActivityBody<
+  ActivityInput,
+  ActivityResultSuccess
+>;
+
+export const activityBody: ActivityBodyImpl = ({ input, logger }) => {
+  logger.info(`INSTALLATION_ID=${input.installationId}`);
+  const nhService = buildNHService(input.notificationHubConfig);
+  return createOrUpdateInstallation(
+    nhService,
+    input.installationId,
+    input.platform,
+    input.pushChannel,
+    input.tags
+  ).bimap(
+    e => retryActivity(logger, `ERROR=${toString(e)}`),
+    ActivityResultSuccess.encode
+  );
 };

HandleNHCreateOrUpdateInstallationCallActivity/index.ts

@@ -1,5 +1,18 @@
-import { getCallNHCreateOrUpdateInstallationActivityHandler } from "./handler";
+import { createActivity } from "../utils/durable/activities";
+import { activityBody, ActivityInput, ActivityResultSuccess } from "./handler";
 
-const activityFunctionHandler = getCallNHCreateOrUpdateInstallationActivityHandler();
+export {
+  ActivityBodyImpl,
+  ActivityInput,
+  ActivityResultSuccess
+} from "./handler";
+export const activityName = "HandleNHCreateOrUpdateInstallationCallActivity";
+
+const activityFunctionHandler = createActivity(
+  activityName,
+  ActivityInput,
+  ActivityResultSuccess,
+  activityBody
+);
 
 export default activityFunctionHandler;