Calendar is slow to open when opening from menu bar icon

[laurentNoudohounsi]

Hi @pakerwreah

Thanks for the great app. I was looking for an alternative to Itsycal that displayed calendar event AND reminders with a nice UI.
It's really great to use your app but I noticed a slight delay between the moment I click on the menu bar icon and the displaying of the calendar.
On the other side, opening a calendar with Itsycal is immediately

Is it something known ?
I guess some time consuming code may running when we open the calendar.
Are we loading all the event and reminder when we click on the menu bar icon ?

Maybe I could help on it.

Thanks

[laurentNoudohounsi]

Quick Update:
After testing again Istycal and Calendar, it seems that the feeling of immediate opening comes from the fact Itscal show the calendar when the mouse click is down. Calendar trigger the even when the mouse is up.

Calendr/Calendr/Main/MainViewController.swift

Lines 854 to 861 in 15bc7bd

	switch event.type {
	case .leftMouseUp:
	self.leftClick.onNext(())
	case .rightMouseUp:
	self.rightClick.onNext(())
	default:
	break
	}

A quick fix to improve the user experience could be to simply replace .leftMouseUp / . rightMouseUp with .leftMouseDown / . rightMouseDown.

What do you think about it @pakerwreah ?

[pakerwreah]

That makes sense.

Feel free to open a PR. It looks pretty simple.

I'm on holidays right now, but I can have a look next week.

[laurentNoudohounsi]

Thanks @pakerwreah .
The PR is here: #259 ;)