Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable opening the calendar in week view #261

Closed
laurentNoudohounsi opened this issue Oct 8, 2024 · 4 comments
Closed

Enable opening the calendar in week view #261

laurentNoudohounsi opened this issue Oct 8, 2024 · 4 comments
Labels
feature New feature or request
Milestone

Comments

@laurentNoudohounsi
Copy link
Contributor

Hello,

I've a proposal regarding the calendar opening view.

Current behavior

The calendar opens in:

  • month view when we click on the calendar icon
  • day view when we double click on a day

Proposed Feature

Would it be a good idea to allow users to open the calendar in week view when they click on a week number?

Implementation Considerations

From my observations, the following steps might be needed to implement this:

  1. Add a case for week in the enum located here: CalendarScript.swift .

  2. use the method calendarScript.openCalendar(at: date, mode: .week) in the WeekNumberCellView.swift.

Alternatively, it might be worth considering making changes in MainViewController.swift and CalendarViewModel.swift to better handle this functionality.

Alternative Proposal
Another possible implementation could be to add an option in the preferences that allows users to choose whether the month view or the week view is opened when they click on the calendar icon.

I’m suggesting this feature because I personally find the week view more useful for most cases. It’s possible that other users might feel the same way.

@laurentNoudohounsi laurentNoudohounsi changed the title Enable to open the calendar with the week view when we click on a week number Enable opening the calendar in week view when clicking on a week number Oct 8, 2024
@pakerwreah pakerwreah added the feature New feature or request label Oct 8, 2024
@pakerwreah pakerwreah added this to the v1.13.4 milestone Oct 8, 2024
@Ariandr
Copy link
Contributor

Ariandr commented Oct 9, 2024

I agree that opening the week view would be really convenient, since the month view isn't that useful for me personally.
But since I don't have week numbers shown, as an additional point to trigger the opening of the week view in the system Calendar I would use these area/labels, since they show the weekly range. It can be a double click too.

image

@pakerwreah
Copy link
Owner

I think that clicking the week names is a very obscure way of triggering it. That's related to the day, not the week.

I don't have week numbers always visible either, I use the shortcut to toggle it on and off when I need it.

I personally prefer the month view, so I believe having a configuration for the calendar button would please everyone.

I'm also assuming we want to open the week from the selected date, because that's the behavior of the month view, it opens in the selected month. That also covers the case where you would click a specific week number.

The default behavior would be opening in the current week, since by default the current date is selected, unless you have "Preserve selected date on hide" enabled, but you can just reset to the current date manually, I'm not gonna create a bunch of exceptions for this feature.

@Ariandr
Copy link
Contributor

Ariandr commented Oct 9, 2024

@pakerwreah
Makes sense, a setting for the button to open either month or week view would be perfect👌

@laurentNoudohounsi
Copy link
Contributor Author

laurentNoudohounsi commented Oct 9, 2024

I think that clicking the week names is a very obscure way of triggering it. That's related to the day, not the week.

@Ariandr I think the same as @pakerwreah. It would be not intuitive to click on a these label to open a week view.

Also, thank you to both of you for pointing that the week numbers isn't always open. I opened it since the beginning so it was natural for me 😅

I personally prefer the month view, so I believe having a configuration for the calendar button would please everyone.

Totally agree! And it will be the most intuitive / easy to implement (without thinking about a lot of uses cases) too.

@pakerwreah pakerwreah changed the title Enable opening the calendar in week view when clicking on a week number Enable opening the calendar in week view Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants