-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow location of nginx.conf to be configurable by environment variable #358
Comments
We're looking for any input that the @paketo-buildpacks/web-servers-maintainers may have on this |
Proposal Sounds good to me.
None of these are blockers. Just wanted to do a quick brain dump in case if it's helpful |
@arjun024 There is currently a PR (#343) that makes the configure binary run as exec.d. I don't think using environment variables would create an issue because we should be able to use them within the configure binary at launch. @robdimsdale I like the name you proposed, |
Currently the location of
nginx.conf
is hard-coded. This buildpack would be more resilient and flexible if this were configurable.There are a couple of use-cases for this:
php-nginx
) can instruct this buildpack as to where it can find the nginx config file that was created earlier in the build processI propose the following configuration:
BP_NGINX_CONF_LOCATION
/workspace/nginx.conf
/workspace/
/
I am happy to move this to an RFC if that process is preferred.
The text was updated successfully, but these errors were encountered: