Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm to RFC RFC0043: Reproducible builds #19

Closed
Tracked by #165
robdimsdale opened this issue Mar 22, 2022 · 2 comments · Fixed by #34
Closed
Tracked by #165

Confirm to RFC RFC0043: Reproducible builds #19

robdimsdale opened this issue Mar 22, 2022 · 2 comments · Fixed by #34
Assignees

Comments

@robdimsdale
Copy link
Member

To confirm to RFC0043 this buildpack should ensure that builds are reproducible. Specifically it should not include a built_at metadata field. In the tests that leverage this field to assert layer reuse, we should instead compare layer SHA values across rebuilds.

See also the tracking issue: paketo-buildpacks/rfcs#165.

@robdimsdale
Copy link
Member Author

As part of this, we should also add an integration test for layer reuse (see https://github.com/paketo-buildpacks/cpython/blob/main/integration/layer_reuse_test.go for an example).

@ForestEckhardt
Copy link
Contributor

@robdimsdale As far as I can tell this buildpack does not actually reuse a layer currently. It has a cache layer that is revived each build but the build happens regardless of the metadata found in the previous build. I think that means a layer reuse test is not necessary. If I am missing something feel free to point it out.

@ForestEckhardt ForestEckhardt self-assigned this Apr 27, 2022
@ForestEckhardt ForestEckhardt mentioned this issue Apr 27, 2022
5 tasks
@sophiewigmore sophiewigmore added hacktoberfest Hacktoberfest eligible and removed good first issue A good first issue to get started with hacktoberfest Hacktoberfest eligible labels Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants