Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minify = True, Doesnt allow rxPaperBook.write? #13

Open
charberSPP opened this issue Aug 8, 2023 · 4 comments
Open

Minify = True, Doesnt allow rxPaperBook.write? #13

charberSPP opened this issue Aug 8, 2023 · 4 comments

Comments

@charberSPP
Copy link

charberSPP commented Aug 8, 2023

Howdy all! Im seeing a reoccuring issue, where after updating gradle (7.0), and creating a release build with minify & Obfuscation set to true, the write(key,object) function consistently throws an error: paperdbexception: couldn't read/deserialize file

Im seeing suggestions to add a -keep the proguard rules, but no keep seems to work. I was hoping someone might have some insight or suggestions?

@pakoito
Copy link
Owner

pakoito commented Aug 13, 2023

I'm not a regular user of the library, maybe someone else knows better and can help in this thread.

I'd start by updating paperdb, maybe applying the instructions they suggest in their readme: https://github.com/pilgr/Paper#proguard-config

@charberSPP
Copy link
Author

charberSPP commented Aug 14, 2023

I've run through their readme instructions a couple dozen times, to no avail, the same issue occurs. Ill also mentioned after some investigation, occasionally the write seems to go through but then the rxPaperbook.read() function is what's actually throwing the paperdbexception: couldn't read/deserialize file, even though the key exists, it doesn't want to deserialize what's saved

@pakoito
Copy link
Owner

pakoito commented Aug 15, 2023

At the end of the day, RxPaper is a thin layer over paper itself. I'd test without it and see if the problem persists.

Have you decompiled your binary and assured that the names are truly being kept?

@raghavsatyadev
Copy link

What rules are you including in proguard? @charberSPP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants