Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Select] customize item equality check #1340

Closed
giladgray opened this issue Jul 13, 2017 · 4 comments
Closed

[Select] customize item equality check #1340

giladgray opened this issue Jul 13, 2017 · 4 comments

Comments

@giladgray
Copy link
Contributor

See #1325 (comment) for original discussion.

Will need to support custom item equality. We cannot rely on === because it immediately falls apart if user creates new objects in each render (a very common React pattern).

@UselessPickles
Copy link
Contributor

Please ensure that the customized equality check is used consistently throughout QueryList, Select, and MultiSelect for both active item and selected item detection.

Is there any estimate for when this will be completed/released? I need to decide whether to wait for this enhancement, or put effort into building a wrapper component that supports dealing with converting values to strict-equality-compatible representative primitives under the hood.

@UselessPickles
Copy link
Contributor

I don't know how I caused this to be unassigned to @brieb

I only added a comment...

@giladgray
Copy link
Contributor Author

@UselessPickles no timeline here. happy to review a PR if you're interested in building this out.

@giladgray
Copy link
Contributor Author

fixed by #3285

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants