-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Select] customize item equality check #1340
Comments
Please ensure that the customized equality check is used consistently throughout QueryList, Select, and MultiSelect for both active item and selected item detection. Is there any estimate for when this will be completed/released? I need to decide whether to wait for this enhancement, or put effort into building a wrapper component that supports dealing with converting values to strict-equality-compatible representative primitives under the hood. |
I don't know how I caused this to be unassigned to @brieb I only added a comment... |
@UselessPickles no timeline here. happy to review a PR if you're interested in building this out. |
fixed by #3285 |
See #1325 (comment) for original discussion.
Will need to support custom item equality. We cannot rely on
===
because it immediately falls apart if user creates new objects in each render (a very common React pattern).The text was updated successfully, but these errors were encountered: