Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DateTime] Fields don't "commit" the inputed date on 'Enter' #1798

Closed
erinmarchand opened this issue Nov 8, 2017 · 6 comments
Closed

[DateTime] Fields don't "commit" the inputed date on 'Enter' #1798

erinmarchand opened this issue Nov 8, 2017 · 6 comments

Comments

@erinmarchand
Copy link

This is a feature request to support the use of "enter" when selecting dates from the Blueprint Date Picker.

@cmslewis
Copy link
Contributor

@erinmarchand Doesn't this already work with DatePicker and DateInput? See these GIFs:

2017-11-10 12 09 20

2017-11-10 12 10 14

@LindsayWard
Copy link

@cmslewis -- Hey Chris,

So if you type into the input, as you have typed a valid date you are it is correctly choosing it in the pop up but if you hit enter it does not move you to the next field or dismiss the flyout. You are correct if you tab thorough and the highlight is actually on the date in the picker (as I show for the end date) it DOES select and it exit appropriately.

datepicker

@cmslewis
Copy link
Contributor

That's a DateRangeInput, a whole different story! @erinmarchand - precision with the component name is appreciated in these issues. Happy to take a look.

@cmslewis cmslewis changed the title Date Picker fields doesn't allow you to use 'enter' [DateRangeInput] Fields don't "commit" the inputed date on 'Enter' Nov 14, 2017
@dalessi
Copy link

dalessi commented Nov 16, 2017

@cmslewis Thoughts on when you might be able to get this in?

@adidahiya
Copy link
Contributor

Unsure when we'll get to this; the best way would be to submit a PR to fix. Shouldn't be too complex.

@cmslewis cmslewis changed the title [DateRangeInput] Fields don't "commit" the inputed date on 'Enter' [DateTime] Fields don't "commit" the inputed date on 'Enter' Nov 20, 2017
@erinmarchand
Copy link
Author

@cmslewis thanks for getting this fixed! Will there be a release soon we can pull from?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants