Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blueprint-classes-constants triggers incorrectly #2855

Closed
johnwiseheart opened this issue Aug 20, 2018 · 1 comment
Closed

blueprint-classes-constants triggers incorrectly #2855

johnwiseheart opened this issue Aug 20, 2018 · 1 comment

Comments

@johnwiseheart
Copy link
Contributor

Environment

  • Package version(s): Latest
  • Browser and OS versions: Any

Steps to reproduce

  1. Use the tslint rule blueprint-classes-constants
  2. Set the className of any element to test-pt-icon

Actual behavior

It gives a warning to use Classes instead.

Expected behavior

It should not give the warning because the classname is not a blueprint class.

Possible solution

Fix the regex in this file so that it ignores classNames which don't begin with pt-.
@johnwiseheart
Copy link
Contributor Author

Ooh looks like this was fixed by #2589. My bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johnwiseheart