-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow build of scss file from blueprintjs package file(s) #2986
Comments
The issue is not relevant anymore after I migrated to react-scripts 2.1.1 from react-scripts-ts. It seems importing blueprint.scss in react app built with react-scripts is working properly. |
Although this issue is closed I didn't manage to get blueprintjs.scss to work. When I import the scss, the build does not fail, but the breadcrumbs' icons don't show (similarly to #3059). Specifically, by inspecting the styles I noticed that this is what I get when importing the scss .bp3-breadcrumbs > li::after {
background: svg-icon("16px/chevron-right.svg", (path: (fill: #5c7080)));
} In contrast, this is what I get when importing the css .bp3-breadcrumbs > li::after {
background: url(data:image/svg+xml,%3csvg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 1…8-.18.29-.43.29-.71 0-.28-.11-.53-.29-.71z' fill='%235C7080'/%3e%3c/svg%3e);
} I'm simply importing the scss like this: @import '~@blueprintjs/core/src/blueprint.scss' Am I doing something wrong? P.S.: I'm using react-scripts 2.1.1 (from official create-react-app) |
You are right. I was wrong reporting the issue is solved. I missed that the breadcrumbs still not working. |
Here is the workaround available: #2976 (comment) |
Environment
Feature request
This is the continuation for #2976 (comment)
I would like to
node-sass
buildblueprintjs.scss
file from theblueprintjs/core
package in my project. This would allow me to restyle and override things the way I would like to. Build of thescss
file depends onsass-inline-svg.js
script which is also included in the package and it is good. But this script requires few SVG icons as.svg
files placed in/resources/icons
which are missed in the distributed package. So the build of thescss
file is failed without these.svg
files. Workaround is to rewrite the script to point out to manually / one-off downloaded required.svg
files. This is not future proof as the upgrade to newer blueprintjs versions will require re-downloading of the required (and potentially new) svg files.Proposed feature: track what
svg
files are referred in thescss
file and include them to the package together withblueprintjs.scss
andsass-inline-svg.js
supporting relatively correct paths.The text was updated successfully, but these errors were encountered: