<Icon />s with an intent in <Tree />s do not have the correct color

[johnwiseheart]

Environment

• Package version(s):

  "@blueprintjs/core": "^3.7.0",
  "@blueprintjs/icons": "^3.2.0",

Steps to reproduce

1. Create a with one element, where the element icon is an with an intent

Actual behavior

It is not the correct color

Expected behavior

It should be the correct color

Extra info

Repro: https://codesandbox.io/s/mj6nnkkmwx

[johnwiseheart]

Not sure why the repro has two icons though 😕

In my use case specifically, I'm seeing this css issue:

[giladgray]

two icons == old CSS file in sandbox (CSS version != JS version).
classic specificity + definition order.

[johnwiseheart]

Hmm, I updated the CSS and it seems fine now - maybe its a bug with having multiple versions of blueprint? https://codesandbox.io/s/9o7r6vjqlr

[giladgray]

yes multiple versions would definitely affect the ordering of CSS rules (and therefore which ones win) in unreliable ways.

[chriswiggins]

Actually, we're having the same problem and it is due to something breaking between 3.6.1 and 3.7.0. The latest release is also broken for trees.

I'll see what I can find and will comment back

[chriswiggins]

The commit from pull #2466 that breaks intent colors on trees is the following: 0df5479

The documentation doesn't have intents on trees as examples so easy to miss I'd say.

How do we go about fixing this? I'm new to blueprint contributions so welcome some guidance for a pull request 👍

[jacekjagiello]

@chrisbellande I've proposed a fix for this in PR #3355, please take a look at it, and let me know if you have a better solution :)