DateRangePicker shortcuts incorrectly dismiss popovers

[mjbcopland]

Environment

• Package: Datetime 3.7.0
• Browser: Chrome 71.0.3578.98
• OS: macOS 10.14

Steps to reproduce

1. Put a DateRangePicker with shortcuts inside a Popover
2. Click one of the shortcuts

Example

https://blueprintjs.com/docs/#datetime/daterangeinput

Actual behaviour

Popover is dismissed

Expected behaviour

Popover should not be dismissed

Possible solution

Use shouldDismissPopover instead of Classes.POPOVER_DISMISS_OVERRIDE.

[adidahiya]

I don't fully understand, can you post a video / gif of the problem and some example code? In the example you linked, the popover does not get dismissed unless you enable the "close on selection" switch.

[adidahiya]

I looked at this more closely through #3668 and I see the OP issue where the popover is dismissed by the POPOVER_DISMISS class and then immediately re-opened by DateRangeInput's controlled setting of <Popover isOpen>. This is a bug.

[apbarratt]

Hi people! I've thrown together a sandbox to demonstrate how the date range picker closes any enclosing popover when a shortcut date is selected. Hope this helps towards finding a fix :)
https://codesandbox.io/embed/blueprint-sandbox-zmnow

[SaenkoM]

As a quick workaround:

const removePopoverDismiss= () => {
  const shortcuts = document.querySelectorAll('.bp3-daterangepicker-shortcuts li .bp3-menu-item')

  shortcuts.forEach((shortcut) => {
    shortcut.classList.remove('bp3-popover-dismiss')
  })
}

popoverProps={{
  ...
  onOpened: removePopoverDismiss,
}}

have to also remove a class on each range change because it is getting added back on shortcut select