[Popover] Popover target should only receive ACTIVE class if uncontrolled

[lucasray]

Environment

• Package version(s): 3.13.0
• Browser and OS versions: All

Steps to reproduce

1. Construct a controlled popover, whose target is a <Button>
2. Set the popover's isOpen to true
3. Observe that the underlying button has bp3-active applied to it

Actual behavior

Button has active class applied.

Expected behavior

Button does not have active class applied.

Possible solution

We have logic in place to apply the bp3-active class on popover targets if the popover is open and the interaction kind is not hover:

blueprint/packages/core/src/components/popover/popover.tsx

Line 339 in 4d5f150

[Classes.ACTIVE]: isOpen && !isHoverInteractionKind,

. This is good for uncontrolled popovers, since the popover likely opened because the user clicked on the target button. However, this is undesirable for controlled popovers that may open without user interaction on the target button (maybe informative popovers which are nudging the user to click the target button).

This line should also check that the popover is in uncontrolled mode and only apply the active class if so.

Edit: a currently fine workaround is to set the interaction kind of the popover to PopoverInteractionKind.HOVER, but this is a semantically unmeaningful fix (interaction kind should have no effect on controlled popovers)