Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultiSelect component crashes on keyboard navigation when no enabled items left. #3612

Closed
fullas opened this issue Jun 19, 2019 · 3 comments
Closed

MultiSelect component crashes on keyboard navigation when no enabled items left. #3612

fullas opened this issue Jun 19, 2019 · 3 comments
Labels
help wanted P1 Package: select Type: bug
Milestone
3.17.0

Comments

@fullas
Copy link

fullas commented Jun 19, 2019

Environment

  • Package version(s):
"@blueprintjs/core": "3.15.1",
"@blueprintjs/select": "3.8.0",
  • Browser and OS versions: Chrome 75, Ubuntu 16.04

Steps to reproduce

  1. Select all items in a MultiSelect component
  2. Close input then open it again
  3. Press down arrow key

Actual behaviour

Crashes

Expected behaviour

Nothing should happen when there are no more items left to select

Possible solution

Possibly related to #3388
@adidahiya adidahiya added this to the next milestone Jun 26, 2019
@jacekjagiello
Copy link
Contributor

@fullas I would like to start working on this, but I can't reproduce crash behavior.
Maybe I'm doing something wrong?

multi_select

@fullas
Copy link
Author

fullas commented Jun 28, 2019 •
edited
Loading

@jacekjagiello Disable selected items in popover.

@jacekjagiello
Copy link
Contributor

@fullas this should be fixed in #3627

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted P1 Package: select Type: bug
Projects
None yet
Milestone
3.17.0
Development

No branches or pull requests
3 participants
@adidahiya @jacekjagiello @fullas