Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse doesn't animate on first open #3788

Closed
pdesoyres opened this issue Oct 21, 2019 · 4 comments · Fixed by #3831
Closed

Collapse doesn't animate on first open #3788

pdesoyres opened this issue Oct 21, 2019 · 4 comments · Fixed by #3831
Assignees
Milestone

Comments

@pdesoyres
Copy link

Environment

  • Package version(s): 3.19.1
  • Browser and OS versions: Google Chrome 77.0.3865.120, Linux Mint 19

Steps to reproduce

  1. clone git blueprint repository
  2. run yarn
  3. run yarn verify
  4. run yarn dev
  5. navigate to http://localhost:9000/#core/components/collapse
  6. click on the "Show build logs" button

Actual behavior

The first Collapse opening is not animated. All other successive close and open plays animation properly.

Expected behavior

An animation should be played at first opening

Possible solution

Exact same issue (#2911) has been fixed but the commit 8ce4d59 introduced the regression.

@alxmiron
Copy link
Contributor

Same for me. Animation regression

@renzholy
Copy link

Same for me

@adidahiya adidahiya self-assigned this Oct 23, 2019
@adidahiya adidahiya added this to the 3.19.x milestone Oct 23, 2019
@mytototo
Copy link

mytototo commented Oct 29, 2019

I have the same issue and want to add a little detail about it: after upgrading to latest version, the closing animation doesn't work at all regardless if it's the first opening or not (it closes well but without the expected animation).

@adidahiya
Copy link
Contributor

Fixed by #3831. Note that this also fixes Tree animations as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants