Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] TagInput has wrong focus styling when intent is specified #3847

Closed
tgreen7 opened this issue Nov 14, 2019 · 1 comment · Fixed by #3855
Closed

[core] TagInput has wrong focus styling when intent is specified #3847

tgreen7 opened this issue Nov 14, 2019 · 1 comment · Fixed by #3855

Comments

@tgreen7
Copy link
Contributor

tgreen7 commented Nov 14, 2019

Environment

  • Package version(s): core: 3.20.0, select: 3.11.2
  • Browser and OS versions: Chrome 78.0.3904.97, MacOS 10.14.6

If possible, link to a minimal repro (fork this code sandbox): https://codesandbox.io/s/blueprint-sandbox-ljjq5

Steps to reproduce

  1. Open codesandbox, focus the select input. Highlight changes to blue. Focus the InputGroup. Highlight stays red.

Actual behavior

Highlight changed to blue on intent: "danger" select.

Expected behavior

Highlight should stay red exactly like the InputGroup does

Possible solution

the .bp3-tag-input has the class .bp3-active which sets the box-shadow to blue. It probably needs some .bp3-intent-danger .bp3-active tweaks to keep it red.

@adidahiya
Copy link
Contributor

it seems to be an issue with TagInput in general... updating issue accordingly.

2019-11-14 11 42 33

@adidahiya adidahiya changed the title Select focus styling overrides intent danger styling [core] TagInput has wrong focus styling when intent is specified Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants