Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay uses legacy context API through react-transition-group #4149

Closed
tanveersingh926 opened this issue May 24, 2020 · 8 comments
Closed

Comments

@tanveersingh926
Copy link

While using the Dialog, I am getting below warning in the console.

index.js:1 Warning: Legacy context API has been detected within a strict-mode tree.

The old API will be supported in all 16.x releases, but applications using it should migrate to the new version.

Please update the following components: TransitionGroup

Learn more about this warning here: https://fb.me/react-legacy-context
    in TransitionGroup (created by Blueprint3.Overlay)
    in Blueprint3.Overlay (created by Blueprint3.Dialog)
    in Blueprint3.Dialog (at Dialog.tsx:16)
    in Dialog (at ViewFormulationDialog.tsx:24)
    in ViewFormulationDialog (at SearchResults.tsx:65)
    in SearchResults (at SearchFormulation.tsx:42)
    in div (created by Blueprint3.Card)
    in Blueprint3.Card (at SearchFormulation.tsx:17)
    in SearchFormulation (at Formulation.tsx:21)
    in Formulation (at AppRouter.tsx:20)
    in div (at Navbar.tsx:63)
    in _Navbar (at AppRouter.tsx:19)
    in Route (at AppRouter.tsx:15)
    in Switch (at AppRouter.tsx:14)
    in Router (at AppRouter.tsx:13)
    in AppRouter (at App.tsx:7)
    in App (at src/index.tsx:9)
    in StrictMode (at src/index.tsx:8) 

@adidahiya adidahiya changed the title Using Dialog getting console warning - Legacy API Overlay uses legacy context API through react-transition-group May 24, 2020
@adidahiya
Copy link
Contributor

I don't think this will be resolved until the next major version of Blueprint, since react-transition-group 3.0 requires react ^16: https://github.com/reactjs/react-transition-group/blob/master/CHANGELOG.md#300-2019-04-15

The next major version of Blueprint will work with v16 and v17, at which point we can upgrade to the latest react-transition-group.

@tanveersingh926
Copy link
Author

Thanks, @adidahiya. Do you have any idea about the release date?

@adidahiya
Copy link
Contributor

No, we don't have a concrete timeline, it's not going to be a priority for us until React 17 is released.

@adidahiya adidahiya added this to the 4.x milestone Jun 29, 2020
@aymenoppa
Copy link

when you'll fix it? is there any workaround except using blueprint CSS

@adidahiya
Copy link
Contributor

I hope to start work on the next major version (Blueprint v4.0) before the end of the year, but no guarantees it will ship before 2021. React 17 isn't even out yet...

@adidahiya
Copy link
Contributor

fixed by #4545, released in 4.0.0-alpha.0

@adidahiya
Copy link
Contributor

Not fixed in v5.0, we still need to migrate to using the nodeRef feature of react-transition-group.

@adidahiya adidahiya reopened this May 5, 2023
@adidahiya adidahiya modified the milestones: 4.0.0-alpha.0, 6.0.0 May 5, 2023
@adidahiya
Copy link
Contributor

Fixed by #6656

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants