Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc Suggestion: Move Dark Theme from Typography to Colors, Classes, or Variables #4750

Open
jgentes opened this issue Jun 8, 2021 · 2 comments

Comments

@jgentes
Copy link

jgentes commented Jun 8, 2021

Just a quick suggestion - I had a hard time (until I searched, of course) finding the specifics for how to use the dark theme.

It seemed odd to me that it wasn't under Colors or Classes or Variables, but was located under Typography. Since it is a theme-wide setting, would it be better to move this elsewhere?

https://blueprintjs.com/docs/versions/4/#core/typography.dark-theme

Great job, btw!

@adidahiya
Copy link
Contributor

Good point, I'll look into moving the section to make it more discoverable.

@adidahiya adidahiya added this to the 4.0.0 milestone Jun 8, 2021
@adidahiya adidahiya modified the milestones: 5.0.0, 5.x May 3, 2023
@adidahiya adidahiya added P1 and removed P2 labels May 3, 2023
@adidahiya adidahiya removed this from the 5.x milestone Jan 31, 2024
@adidahiya adidahiya removed their assignment Jan 31, 2024
@adidahiya

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants