Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misplaced Popover arrow when Popover content changes size #476

Closed
acolombi opened this issue Jan 13, 2017 · 2 comments
Closed

Misplaced Popover arrow when Popover content changes size #476

acolombi opened this issue Jan 13, 2017 · 2 comments

Comments

@acolombi
Copy link
Contributor

Rather than try to explain it, I'll let this video do the talking:

https://videos.palantir.com/media/popover+and+daterangepicker/0_jy1i0owk

Understood that this is only available to Palantir employees, but it's a complex issue that's easily described in video form.

@llorca llorca added this to the 1.7.0 milestone Jan 13, 2017
@leebyp leebyp self-assigned this Jan 13, 2017
@leebyp
Copy link
Contributor

leebyp commented Jan 19, 2017

Problem in question arises when the contents in a Popover changes size without the state changing (as shown here with the DateRangePicker):

daterangepicker in popover

The problem resolves when the Popover inline prop is set to true. I experimented with

  • having the Popover passing down an updatePopover handler to it's contents
  • the Popover uses a setInterval to check the size of it's contents and forceUpdates accordingly

Neither feels satisfactory to me. Thoughts? @palantir/blueprint

@llorca llorca modified the milestones: 1.7.0, 1.8.0 Jan 27, 2017
@giladgray giladgray modified the milestones: 1.8.0, 1.9.0 Feb 3, 2017
@leebyp
Copy link
Contributor

leebyp commented Feb 6, 2017

Closing as won't fix.
If the inline solution doesn't work, another way to solve would be to control both the Popover and the Contents from the parent element and use ref in React accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants