Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MultistepDialog] Allow side navigation to be disabled (e.g. when submitting) #4872

Open
saruman1234 opened this issue Aug 20, 2021 · 3 comments

Comments

@saruman1234
Copy link

saruman1234 commented Aug 20, 2021

Environment

  • Package version(s): @blueprintjs/core@3.48.0

Feature Request

  1. Add a disabled prop to <MultistepDialog> that would allow the side navigation to be disabled (e.g when the dialog is being submitted)

  2. Perhaps if specified true (and ignored as false | undefined), it could also combine & override any individual disabled props for all the other steps' nextButtonProps and backButtonProps? (You can see in my Code Sandbox example, I am passing || submitting through to most of them)

Code Sandbox

https://codesandbox.io/s/blueprint-sandbox-multistepdialog-4di0d

Steps to reproduce

(Using the example in the Code Sandbox)

  1. Advance through each step of the <MultistepDialog> to the end.
  2. See how each step must be "valid" before you can progress.
  3. On the last step, click the "Submit" button to trigger a fake submit state.
  4. ❌ See that you can still navigate around between past steps via the side navigation whilst the form submit is ongoing.
@adidahiya
Copy link
Contributor

Makes sense. This sounds like a reasonable feature request. We should provide a way to disable the step list in this scenario from your sandbox:

2021-08-23 14 18 07

@suwignyo
Copy link

To add to this, is it possible for the left panel to also be hidden completely or would you just suggest using and doing my own pagination?

@adidahiya
Copy link
Contributor

@suwignyo hmm, yeah I suppose I would be open to adding that option. but that would be a separate request, can you file another issue please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To do
Development

Successfully merging a pull request may close this issue.

3 participants