Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table with ghost cells continues to scroll when there are no more rows #5027

Closed
mattskrobola opened this issue Nov 17, 2021 · 3 comments
Closed

Comments

@mattskrobola
Copy link
Contributor

Environment

  • Package version(s): blueprint 4 core and table

Code Sandbox

Link to a minimal repro:
https://codesandbox.io/s/cool-benz-es9oo?file=/src/App.js

Steps to reproduce

Create a scrollable Table with enableGhostCells set to true

Actual behavior

Scrollbar continues to scroll when reaching the bottom of the table. Also grabbing the scrollbar and dragging down creates more ghost rows.
scrolling

Expected behavior

The scrollbar stops scrolling when it reached the bottom of the table

Notes:
Scrolling over a frozen column to the bottom of the table behaves as normal

@adidahiya
Copy link
Contributor

I've isolated the bug to occur between table v3.8.0 – v3.8.1

not present in v3.8.0: https://codesandbox.io/s/modern-sound-z9ul4?file=/src/App.js
present in v3.8.1: https://codesandbox.io/s/awesome-rumple-k40zq?file=/src/App.js

@adidahiya adidahiya changed the title [v4] Table continues to scroll when there are no more rows Table continues to scroll when there are no more rows Nov 17, 2021
@adidahiya adidahiya changed the title Table continues to scroll when there are no more rows Table with ghost cells continues to scroll when there are no more rows Nov 17, 2021
@mattskrobola
Copy link
Contributor Author

From reverting commits locally #3771 seems to be the PR that caused this cc @adidahiya

@adidahiya
Copy link
Contributor

Fixed in v4 by #5115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants