You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After migrating to version 5.x.x, I noticed that OverlayToaster does not accept children anymore. I suspect this was not intended?
There are still examples about it here: https://blueprintjs.com/docs/#core/components/toast.overlaytoaster
And also there was no mention of deprecating children and only using the recommended consumption in the changelog
The text was updated successfully, but these errors were encountered:
@SiimTa are you using @types/react v18? Do you have a code sandbox link to repro the issue?
Removal of the children API for <OverlayToaster> was not intended in v5.0. I think this should be an easy fix, we just need to explicitly declare children as a prop in OverlayToasterProps, similar to this PR where we did it for other class components: #5266
If you don't define any other props, it works fine. But as soon as I define anything("position" in that case), it cannot find the children prop.
adidahiya
changed the title
OverlayToaster does not accept children as props
OverlayToaster does not accept children as props with @types/react v18
Aug 31, 2023
Environment
Problem
After migrating to version 5.x.x, I noticed that OverlayToaster does not accept children anymore. I suspect this was not intended?
There are still examples about it here: https://blueprintjs.com/docs/#core/components/toast.overlaytoaster
And also there was no mention of deprecating children and only using the recommended consumption in the changelog
The text was updated successfully, but these errors were encountered: