Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move retry logic into middleware #81

Open
whickman opened this issue Feb 12, 2020 · 0 comments
Open

Move retry logic into middleware #81

whickman opened this issue Feb 12, 2020 · 0 comments

Comments

@whickman
Copy link
Contributor

What happened?

Currently retry logic happens in the client at the layer above the middleware. Because error decoding a response body to be nil (see [0]), the retry logic cannot inspect headers and therefore cannot do any advanced handling of http codes >= 400.

What did you want to happen?

If the retry logic were to be moved into the middleware and run before the error decoding middleware, we would be able to inspect these headers.

[0] #78 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant