Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Human readable time types #152

Closed
vandervecken opened this issue Nov 12, 2018 · 6 comments
Closed

Human readable time types #152

vandervecken opened this issue Nov 12, 2018 · 6 comments

Comments

@vandervecken
Copy link

Can we provide human readable time types for weeks and months?
Useful for Foundry Retention.

@markelliot
Copy link

@vandervecken
Copy link
Author

I tried that repo originally. That link above is not visible to me on GH. @vinooganesh informed me that this is because that repo is private, likely because it may be deprecated in favour of conjure.

@markelliot
Copy link

I think it's an oversight that it's not public, it's not deprecated.

@vinooganesh
Copy link

for clarity's sake, my statement was not that because the repo is private that would mean that this is deprecated. thought that was was strange that the repo was private, and given similar code here, was wondering if we were encouraging people to use conjure's version instead: https://github.com/palantir/conjure-java-runtime-api/blob/develop/service-config/src/main/java/com/palantir/conjure/java/api/config/service/HumanReadableDuration.java#L43

@vandervecken
Copy link
Author

Ok, so can you make that repo public so I can add an issue to it (or figure out who can do this)?

@vandervecken
Copy link
Author

Got access and filed palantir/human-readable-types#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants