Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't filter out nodes by score only once in the balanced node selector #83

Open
sfackler opened this issue Dec 31, 2020 · 0 comments
Open

Comments

@sfackler
Copy link
Member

To make the implementation more simple, the balanced node selector currently only filters out nodes with high scores once when first building its future, and then selects only on the non-filtered nodes from there. This makes the selector slightly less responsive to score changes while a request is processing which is in theory bad. It's not clear how much this actually matters though.

Fixing it would probably involve wrapping the node score in an async semaphore, and having the future have state for each node that's always waiting for the score to change, and then also waiting on the limiter for nodes that score sufficiently well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant