Remove double-keyed sets and maps #174
Conversation
|
The workaround would probably be to either add code generation functionality to skip specific objects and endpoints, or to edit the test IR file and filter the offending bits out there. |
|
The later sounds simpler and more palatable to me. Would you be ok going that route instead? |
|
what does the conjure spec say about this? |
|
The conjure spec says they need to behave like they do in Java, which is a problem for other languages: palantir/conjure#178 |
|
ok, thanks @sfackler . Then I think we need to change the tests and the spec at the same time, and also update the parsers and the java implementation to outlaw such objects, and offer users a migration path. just removing the tests in not OK, IMO. |
|
This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days. |
Before this PR
Rust doesn't support double-keyed maps and sets, and Go has significant difficulties implementing the required behavior as well.
On the Rust side in particular, we can't simply ignore those tests since the generated code from the Conjure definitions doesn't even compile.
After this PR
The offending types and tests cases are removed.
Fixes #173