Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

receiveBinaryAliasExample behaves weirdly #296

Open
sfackler opened this issue Jan 8, 2020 · 1 comment
Open

receiveBinaryAliasExample behaves weirdly #296

sfackler opened this issue Jan 8, 2020 · 1 comment

Comments

@sfackler
Copy link
Member

sfackler commented Jan 8, 2020

What happened?

The receiveBinaryAliasExample client test receives a binary request body (i.e. application/octet-stream) from the test server, but the server then expects the client to respond with the JSON base64 representation on the confirm endpoint. This doesn't work with the new Conjure definitions added in #295, and requires hacky special casing in the Typescript tests: https://github.com/palantir/conjure-typescript/blob/develop/src/__integTest__/tests.ts#L79-L86.

What did you want to happen?

If the test wants to check JSON encoding of binary aliases, it should wrap the alias in an object so it is consistently JSON encoded. If it wants to check the raw encoding of binary aliases, it should work with octet-streams on both ends.

@robert3005
Copy link
Contributor

The problem was that confirm endpoint had any type and that had to be json. If you have confirm that's endpoint specific you can generate the right bindings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants