You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The receiveBinaryAliasExample client test receives a binary request body (i.e. application/octet-stream) from the test server, but the server then expects the client to respond with the JSON base64 representation on the confirm endpoint. This doesn't work with the new Conjure definitions added in #295, and requires hacky special casing in the Typescript tests: https://github.com/palantir/conjure-typescript/blob/develop/src/__integTest__/tests.ts#L79-L86.
What did you want to happen?
If the test wants to check JSON encoding of binary aliases, it should wrap the alias in an object so it is consistently JSON encoded. If it wants to check the raw encoding of binary aliases, it should work with octet-streams on both ends.
The text was updated successfully, but these errors were encountered:
The problem was that confirm endpoint had any type and that had to be json. If you have confirm that's endpoint specific you can generate the right bindings
What happened?
The receiveBinaryAliasExample client test receives a binary request body (i.e.
application/octet-stream
) from the test server, but the server then expects the client to respond with the JSON base64 representation on the confirm endpoint. This doesn't work with the new Conjure definitions added in #295, and requires hacky special casing in the Typescript tests: https://github.com/palantir/conjure-typescript/blob/develop/src/__integTest__/tests.ts#L79-L86.What did you want to happen?
If the test wants to check JSON encoding of binary aliases, it should wrap the alias in an object so it is consistently JSON encoded. If it wants to check the raw encoding of binary aliases, it should work with octet-streams on both ends.
The text was updated successfully, but these errors were encountered: