Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoDeserialize tests returning null for collections should be positive tests #299

Open
sfackler opened this issue Jan 8, 2020 · 0 comments

Comments

@sfackler
Copy link
Member

sfackler commented Jan 8, 2020

What happened?

In the client autoDeserialize tests, there are negative tests for all of the collection-returning endpoints (e.g. receiveListBearerTokenAliasExample) of null. I think the idea is that it's there to test that clients reject a 200 response with a body of null, but the verification server actually sends a 204, which is a valid response according to the spec: https://github.com/palantir/conjure/blob/master/docs/spec/wire.md#31-status-codes

Screen Shot 2020-01-08 at 10 31 28 AM

Note that the response for test 2 of receiveListBearerTokenAliasExample (the null test) returns 204 in packet 247.

What did you want to happen?

These should either be moved to positive tests, or the verification server should return a 200.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant