Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RetryingChannel leaks response bodies when the returned future is cancelled #315

Closed
carterkozak opened this issue Feb 11, 2020 · 1 comment

Comments

@carterkozak
Copy link
Contributor

What happened?

Future.cancel completes the SettableFuture instance so a real response is leaked without being closed.

What did you want to happen?

Resources should not be leaked.

@iamdanfox
Copy link
Contributor

Fixed by #350

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants