Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add errorprone check to avoid immutables Style inline + meta-annnotation #1395

Closed
a10y opened this issue Jun 8, 2020 · 1 comment
Closed

Comments

@a10y
Copy link
Contributor

a10y commented Jun 8, 2020

What happened?

We had a production issue where an immutables data object for configuration had a common style meta-annotation applied. A code-change was introduced that added a @Value.Style() annotation to expose public access to a Builder.

Because immutables does no merging of style annotations, this overrode the meta-annotation, breaking config deserialization for dozens of production deployments.

What did you want to happen?

The user should be told that this is going to produce unexpected behavior and that they should either

  • Incorporate their style changes into the meta-annotation
  • Inline the meta-annotations fields into the inline style declaration
@a10y
Copy link
Contributor Author

a10y commented Jun 16, 2020

Fixed in #1396

@a10y a10y closed this as completed Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant