Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaselineExactDependencies should filter for only jar artifacts #594

Closed
gatesn opened this issue Apr 2, 2019 · 1 comment · Fixed by #773
Closed

BaselineExactDependencies should filter for only jar artifacts #594

gatesn opened this issue Apr 2, 2019 · 1 comment · Fixed by #773

Comments

@gatesn
Copy link
Contributor

gatesn commented Apr 2, 2019

We use the jar analyzer, meaning it breaks when taking a dependency on a pom file for example

@robert3005
Copy link
Contributor

robert3005 commented Aug 2, 2019

This manifests in

Caused by: java.lang.IllegalArgumentException: Cannot accept visitor on URL: file:/Users/robertk/.gradle/caches/modules-2/files-2.1/org.apache.spark/spark-dist_2.11-hadoop-palantir/3.0.0-palantir.32/5413978ef8b201b92ba5b6514d8d9167a778d9e3/spark-dist_2.11-hadoop-palantir-3.0.0-palantir.32.pom
        at org.apache.maven.shared.dependency.analyzer.ClassFileVisitorUtils.accept(ClassFileVisitorUtils.java:75)
        at org.apache.maven.shared.dependency.analyzer.DefaultClassAnalyzer.analyze(DefaultClassAnalyzer.java:48)
        at com.palantir.baseline.plugins.BaselineExactDependencies$Indexes.lambda$populateIndexes$2(BaselineExactDependencies.java:106)
        at com.palantir.baseline.plugins.BaselineExactDependencies$Indexes.populateIndexes(BaselineExactDependencies.java:103)
        at com.palantir.baseline.tasks.CheckUnusedDependenciesTask.checkUnusedDependencies(CheckUnusedDependenciesTask.java:67)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants