Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: Add CaptureRuntimeMemStatsWithCancel function #124

Merged
merged 2 commits into from
Nov 16, 2018
Merged

metrics: Add CaptureRuntimeMemStatsWithCancel function #124

merged 2 commits into from
Nov 16, 2018

Conversation

nmiyake
Copy link
Contributor

@nmiyake nmiyake commented Nov 15, 2018 •
edited
Loading

This change is Reviewable

@nmiyake
Update API to improve usability
ac0391b 
* Do not return cancel function (caller can create their own context
  with cancel if they want the behavior)
* Return a bool to signal whether or not goroutine was started
* Update function name and documentation
@nmiyake
Copy link
Contributor Author

nmiyake commented Nov 16, 2018

@bmoylan updated the implementation a bit after further consideration

@nmiyake nmiyake merged commit 66645f2 into master Nov 16, 2018
@nmiyake nmiyake deleted the addMetricsRuntimeWithCancel branch November 16, 2018 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmoylan bmoylan bmoylan approved these changes

Assignees

@bmoylan bmoylan

@andybradshaw andybradshaw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nmiyake @bmoylan @andybradshaw