Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Env Variables for Options in Server Config #363

Closed
devinburnette opened this issue Jan 14, 2022 · 1 comment · Fixed by #364
Closed

Support Env Variables for Options in Server Config #363

devinburnette opened this issue Jan 14, 2022 · 1 comment · Fixed by #364

Comments

@devinburnette
Copy link
Contributor

Hello again!

We're looking at setting up a shared repository that isn't the default .github repository. I see the option for it in the server config to change where policy bot looks for a shared policy config, but I don't see that as being a currently supported Env variable. We could probably just as easy deploy a config file with this in it, but so far this is the only thing and Env variables are a lot easier for us to manage.

Would you accept a PR to make the server config parser set options from Env before filling the defaults?

@bluekeyes
Copy link
Member

Sure, we already do this for some values (the HTTP server options, GitHub configuration, and secrets), but have been pretty haphazard about adding environment variable support for other options. If you'd like to take a pass at adding in missing ones, that would definitely be appreciated, but I'm also happy to accept a PR that just adds the one variable you need right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants