Skip to content

Fix failing pylint test #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 30, 2019
Merged

Fix failing pylint test #663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8bb411f
fix failing pylint test #661
youben11 Sep 30, 2019
7048c35
ignoring the test for python2
youben11 Sep 30, 2019
6b35a2f
adding a different test for python2
youben11 Sep 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions test/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
# Copyright 2017 Palantir Technologies, Inc.
import sys
import pytest
from pyls import IS_WIN

IS_PY3 = sys.version_info.major == 3

unix_only = pytest.mark.skipif(IS_WIN, reason="Unix only")
windows_only = pytest.mark.skipif(not IS_WIN, reason="Windows only")
py3_only = pytest.mark.skipif(not IS_PY3, reason="Python3 only")
py2_only = pytest.mark.skipif(IS_PY3, reason="Python2 only")
15 changes: 14 additions & 1 deletion test/plugins/test_pylint_lint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import os
import tempfile

from test import py2_only, py3_only
from pyls import lsp, uris
from pyls.workspace import Document
from pyls.plugins import pylint_lint
Expand Down Expand Up @@ -49,7 +50,19 @@ def test_pylint(config):
assert unused_import['severity'] == lsp.DiagnosticSeverity.Warning


def test_syntax_error_pylint(config):
@py3_only
def test_syntax_error_pylint_py3(config):
with temp_document(DOC_SYNTAX_ERR) as doc:
diag = pylint_lint.pyls_lint(config, doc, True)[0]

assert diag['message'].startswith('[syntax-error] invalid syntax')
# Pylint doesn't give column numbers for invalid syntax.
assert diag['range']['start'] == {'line': 0, 'character': 12}
assert diag['severity'] == lsp.DiagnosticSeverity.Error


@py2_only
def test_syntax_error_pylint_py2(config):
with temp_document(DOC_SYNTAX_ERR) as doc:
diag = pylint_lint.pyls_lint(config, doc, True)[0]

Expand Down