New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why does SafeLoggable not provide SafeArgs? #6

Open

uschi2000 opened this issue May 31, 2017 · 1 comment

uschi2000 commented May 31, 2017

SafeLoggable returns Args, but should return SafeArgs?

https://github.com/palantir/safe-logging/blob/develop/safe-logging/src/main/java/com/palantir/logsafe/SafeLoggable.java#L28

Contributor

nziebart commented May 31, 2017

We actually want it to be able to return both kinds of args. Maybe we should rename the interface to LoggableException?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment