Skip to content
This repository has been archived by the owner on Oct 6, 2020. It is now read-only.

Error description window disappear instantly if start of the line is not on screen #10

Open
MauricioFerraz opened this issue Jul 30, 2019 · 6 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@MauricioFerraz
Copy link

Bug Report

  • TSLint version:
  • TypeScript version:
  • Running TSLint via: (pick one) CLI / Node.js API / VSCode / grunt-tslint / Atom / Visual Studio / etc

Reproduction using TSLint Playground

tslint-playground

TypeScript code being linted

just any long line with an error

with tslint.json configuration:

default

Actual behavior

If you scroll a wide page to the right, to the point where you can't see the start of the line anymore, the error description window, that usually shows when you hover your mouse over the line, simply pops in and out of existence.

clip showing the bug in action

Expected behavior

The window should show regardless of the start of the line being in sight or not.

@adidahiya adidahiya transferred this issue from palantir/tslint Jul 30, 2019
@adidahiya adidahiya added bug Something isn't working help wanted Extra attention is needed labels Jul 30, 2019
@MauricioFerraz
Copy link
Author

I've noticed that it happens when the beginning of the highlighted portion of the code isn't on the screen:
example running in Visual Studio Code

@MauricioFerraz
Copy link
Author

May I request that this issue be transferred back to palantir/tslint, since it doesn't happen only in the TSLint Playground?

@adidahiya
Copy link

tslint has no control over how its errors are displayed... this bug is specifically related to a GUI so I don't think it belongs in the tslint repo

@MauricioFerraz
Copy link
Author

Yeah, I actually noticed that today. Even without tslint, vscode still shows the same behavior, so I'll try placing this issue there.
Thanks!

@MauricioFerraz
Copy link
Author

MauricioFerraz commented Jul 31, 2019

On the other hand, the playground might still benefit from trying to fix it as well, so maybe closing it here was a bit rushed.
Your call if it should be reopened.

And I've found out that they've fixed it on the insiders version.

@adidahiya
Copy link

We can probably get the same bugfix if we just update monaco-editor. Reopening to track that

@adidahiya adidahiya reopened this Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants